-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sourcebundle): Add callback to handle skipped files #864
Conversation
Add a callback to SourceBundleWriter that is called every time we skip adding a file to the bundle due to a ReadFailed error. Closes #863
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an elegant way of doing it!
Yeah, many thanks to @jan-auer for helping me to come up with this idea! We are fully backwards compatible in this way |
@loewenheim I also had the idea that we could similarly add a |
It's something to think about. |
Co-authored-by: Jan Michael Auer <jan.auer@sentry.io>
Since #860 was closed, does that mean that sentry-cli also handles this now in some way already? What would be the behavior now when a file is to be skipped? Bail out, warning, or silent debug log? (assuming either option would now log the file name) |
Add a callback to SourceBundleWriter that is called every time we skip adding a file to the bundle due to a ReadFailed error.
Also, #861 missed another spot where the ReadFailed error can cause the write function to fail; this PR fixes that.
Closes #863
Fixes #860